-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add [read-database] config #73
base: main
Are you sure you want to change the base?
Conversation
@pfrayer thanks for the PR! Can you check the used email address in the commit? It isn't associated with your github account. |
e1b9112
to
f203497
Compare
@bastelfreak my bad, fixed |
I think this is also a breaking change, because now you would have to make sure that you have a read user created. If someone simply updates the container with an already running configuration, this breaks. |
You are right, as-is this is a breaking change. |
okay, so i should wait with the merge? or will you do another PR? ... just doing a v1.6.0 to preserve the present state and then i wanted to merge this one an do a 2.0.0 release. if if we could have a condition, that would be greate |
Yes wait before merging this PR, I'll update it with the condition stuff. |
978232c
to
89e2f8d
Compare
Sorry for the delay I was in holiday (so not so sorry) I added the conditional logic about this read-database config. The idea is:
Please tell me if this logic is OK for you |
ah dang it. ci fails because cannot access the secrets from a fork-pr. will investigate later... |
PuppetDB supports a
[read-database]
settings: https://www.puppet.com/docs/puppetdb/8/configure.html#read-database-settingsPuppetDB needs to have 2 database users: one with RW, one with RO
It's mentioned in #43
This PR adds a simple
read-database.conf
in/etc/puppetlabs/puppetdb/conf.d/
to use this feature.The default values for user comes from the official documentation: https://www.puppet.com/docs/puppetdb/8/configure_postgres.html