Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Volcano Supports K8s v1.31 #3767

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

vie-serendipity
Copy link

I split the content into four commits.

  1. change go mod
  2. upgrade KUBE_VERSION
  3. solve some api changes after adaptation
  4. sync changes regarding volumebing

I have two tasks to be completed.

  • introduce the updated version of volcano apis, because the pr hasn't been merged yet
  • update README after running e2e tests, unit tests has passed already

@volcano-sh-bot
Copy link
Contributor

Welcome @vie-serendipity!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hzxuzhonghu
You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 12, 2024
@Monokaix
Copy link
Member

great job!

@Monokaix
Copy link
Member

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 16, 2024
@vie-serendipity
Copy link
Author

I'll fix these issues to pass the test.

@Monokaix
Copy link
Member

You can also refer to 1.30 adaptation #3556 : )

feat: upgrade controller-gen to 0.16.4 and make manifests

Signed-off-by: vie-serendipity <[email protected]>
@@ -24,9 +24,10 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/component-helpers/storage/volume"
"k8s.io/klog/v2/ktesting"
"k8s.io/kubernetes/pkg/scheduler/util/assumecache"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!are volumebinding codes synced from k8s?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Monokaix
Copy link
Member

Please notice that to keep API compatibility,we should modify the code CSIStorageCapacityInformer: fh.SharedInformerFactory().Storage().V1().CSIStorageCapacities() in file pkg/scheduler/capabilities/volumebinding/volume_binding.go, and change from V1() to V1beta1() and test whether v1beat1 is supported in k8s v1.31: )

@vie-serendipity
Copy link
Author

@Monokaix Thanks for your comment, I've already updated the volume binding-related code and changed v1 to v1beta1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants