-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Volcano Supports K8s v1.31 #3767
base: master
Are you sure you want to change the base?
feat: Volcano Supports K8s v1.31 #3767
Conversation
Welcome @vie-serendipity! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
great job! |
/ok-to-test |
I'll fix these issues to pass the test. |
You can also refer to 1.30 adaptation #3556 : ) |
Signed-off-by: vie-serendipity <[email protected]>
Signed-off-by: vie-serendipity <[email protected]>
Signed-off-by: vie-serendipity <[email protected]>
Signed-off-by: vie-serendipity <[email protected]>
…ntroller gen Signed-off-by: vie-serendipity <[email protected]>
0a452d1
to
0de4e96
Compare
feat: upgrade controller-gen to 0.16.4 and make manifests Signed-off-by: vie-serendipity <[email protected]>
1754291
to
d50b35b
Compare
Signed-off-by: vie-serendipity <[email protected]>
@@ -24,9 +24,10 @@ import ( | |||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
"k8s.io/component-helpers/storage/volume" | |||
"k8s.io/klog/v2/ktesting" | |||
"k8s.io/kubernetes/pkg/scheduler/util/assumecache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!are volumebinding codes synced from k8s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Please notice that to keep API compatibility,we should modify the code |
Signed-off-by: vie-serendipity <[email protected]>
@Monokaix Thanks for your comment, I've already updated the volume binding-related code and changed v1 to v1beta1. |
f0bdf2b
to
7cd5545
Compare
I split the content into four commits.
I have two tasks to be completed.