-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: pantheon-session-20200331 #20538
Conversation
@xtraeme You don't review this PR? |
This pr is ready! Actually that pr is based on my initial attempts. He didn't even change my name! |
fa9b5c5
to
681fd25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good, but I have a few concerns that I wrote in-line. The issues are pretty similar so I will explain them once here:
- cmake is rarely needed to build elementary software these days. Most packages will use meson in place of cmake, and (almost?) never both at the same time.
- vala-devel is for software that links to the vala utility libraries. Most applications written in Vala will not need it. It is only really useful for IDEs and text editors that need to do syntax highlighting etc. Usually you will want to put
valac
(the vala compiler) in hostmakedepends. - subpackages that contain development headers typically have a depends line that looks like
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
. You can see many examples of this in the void-packages repo already.
Failed in some architectures. For instance: Should i add vala to |
See my message above about vala-devel vs. valac and when you want to use each one. Use the commits from #20429 as-is -- they successfully cross compile just fine. |
Ok. But i'm confused about one thing: |
5d49726
to
6f62ee5
Compare
The last update looks great. My only remaining concern is if there are any missing runtime dependencies. These can be hard to detect if you are not working from the base install. I would suggest spinning up a minimal void installation in a VM and installing these packages, then making sure they work well without having to install anything else. I do not think this concern should be a blocker for merging, we can always easily add those missing deps later. Thanks for your hard work on this! |
@LinArcX would you be kind enough and tell me which PRs (and pkgs) I have to recompile because you've fixed some issues with them? Thank you! |
Just re-compile pantheon-session. Edit: A dirty way:
Grab those hash IDs and make a url in your browser like this: And search for LinArcX there. |
@LinArcX I've reapplied this PR as patch on my gitsrc, recompiled So now I disable my lightdm auto-launch and try to figure out why that is. Meanwhile I've created a meta package for all default elementary apps which makes it easier for me to package & install pantheon. # Template file for 'pantheon-apps-default'
pkgname=pantheon-apps-default
version=1.0.0
revision=1
build_style=meta
depends="io.elementary.terminal io.elementary.calculator io.elementary.files
io.elementary.icons io.elementary.calendar io.elementary.code
io.elementary.music io.elementary.videos io.elementary.photos
io.elementary.print pantheon-screenshot"
short_desc="Default Pantheon applications"
maintainer="Anachron <[email protected]>"
license="LGPL-2.1-or-later"
homepage="https://github.com/elementary" Edit: Turns out the Manually running it gives me Maybe this is the issue? |
@Anachron I experienced crash after latest changes randomly. But i didn't know that we shouldn't insert this entry: Into this file: So, please remove that entry from above file and try again. Edit: Seems every crash somehow related to this file. :) |
I've added myself to |
There is no need to add yourself to |
Sorry if I wasn't clear enough, I tried running that polkit agent you mentioned and yet still receive the same error. Edit: |
Could you please give me the content of this file: |
…p.agent-polkit.desktop
Done.
Done. And also i removed |
Opening the Power switchboard plug crashes now with the message We still have the issue for me that the User Session menu cannot be used at all. Also now when we install wingpanel indicators before the lightdm login there are two wingpanels spawned, one from Last but not least the locales default to Edit: |
Any progress? |
On real machine, I hadn't any issue with it.(for about two months) |
@LinArcX can you check it on a Virtual Machine as well and see if you can confirm my issues? |
@Anachron If anybody interest, can continue my work and finish this. |
@LinArcX feel free to close the PR if you do not intend to update the branch |
@ahesford and I have closed the related individual PRs. If there was some specific application out of those that you still wish to include, feel free to reopen the PR for it. |
Finally pantheon desktop is ready for void users!
To use it, you have two options:
1.1. There is a greeter for pantheon, and i'm going to send it as a separate PR.
startx
(has some drawback)Edit your
.xinitrc
file like this:And run this command:
sh -c "/usr/bin/startx /home/linarcx/.xinitrc pantheon; killall -9 wingpanel; killall -9 plank; killall -9 gala"
Bonus: To make life even easier, make an alias in your
.zshrc
or.bashrc
file:alias startp='sh -c "/usr/bin/startx ~/.xinitrc pantheon"'
Switchboard
One of core components of pantheon-session is switchboard and its indicators. Please notice that I've intentionally didn't include any switchboard-plugins. Instead I've created most of them as extra packages and you can install them as you want:(I'm going to send them as separate pull requests after this PR merged)
Official:
libsignon-glib
]systemd
dependency ]Unofficial:
Wingpanel
There are lots of them(Official or Unofficial). I'm tying to create most of them. (like switchboard-plugin, I'm going to send them as separate PRs):
Official:
Unofficial:
wingpanel-indicator-weather [ needs patching! ](in favor ofwingpanel-indicator-adstruo
)Greeter
Hint: to use
lightdm-patnehon-greeter
, first installlightdm
and enable it's service. Then installlightdm-pantheon-greeter
. You can set the default greeter by changing the[Seat:*]
section of the LightDM configuration file [/etc/lightdm/lightdm.conf
], like so:One way to check which greeters are available is to list the files in the
/usr/share/xgreeters
directory; each.desktop
file represents an available greeter. In this example, the lightdm-gtk-greeter and lightdm-kde-greeter greeters are available:And the config file of pantheon-greeter[
/etc/lightdm/io.elementary.greeter.conf
] contains:Theme & Icons