Enable SDKv2 s3 debug logs #207
Open
+197
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
sdk-v2-logging
branch
2 times, most recently
from
aec0092
to
55e92a6
Compare
kaovilai
commented
Jun 28, 2024
| }), | ||
| ), | ||
| config.WithLogger(awsLogger), | ||
| config.WithClientLogMode(aws.LogRequest|aws.LogResponse|aws.LogRetries|aws.LogSigning), |
There was a problem hiding this comment.
Please feedback on which logs to enable and/or if we need to make this configurable.
kaovilai
force-pushed
the
sdk-v2-logging
branch
2 times, most recently
from
9e16cf8
to
d736b23
Compare
kaovilai
commented
Jul 1, 2024
Comment on lines
143
to
152
| cfg, err := newConfigBuilder(o.log).WithTLSSettings(insecureSkipTLSVerify, caCert).Build() | ||
| cfg, err := newConfigBuilder(o.log).WithTLSSettings(insecureSkipTLSVerify, caCert).WithClientLogMode().Build() |
There was a problem hiding this comment.
Looks like this is not needed, unless we want logs for region discovery too.
kaovilai
commented
Jul 1, 2024
kaovilai
force-pushed
the
sdk-v2-logging
branch
8 times, most recently
from
d87a2e9
to
f6f468e
Compare
kaovilai
commented
Jul 3, 2024
kaovilai
force-pushed
the
sdk-v2-logging
branch
4 times, most recently
from
b12f7f3
to
41b19b5
Compare
sseago
previously approved these changes
Jul 12, 2024
|
This might also help determine vmware-tanzu/velero#8152 as to which value was passed in header x-amz-content-sha256 |
Signed-off-by: Tiger Kaovilai <[email protected]> remove commented code. Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai
force-pushed
the
sdk-v2-logging
branch
from
41b19b5
to
70632b5
Compare
sseago
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For aws sdkv2, there are no logging by default. This PR enables debug logging from the SDK.
Helps with vmware-tanzu/velero#7543
Sets ClientLogMode https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/logging/#clientlogmode and add plugin logger to config/options
This should assists in debugging requests/responses, especially with the recent rise in issues
Signed-off-by: Tiger Kaovilai [email protected]
image:
ghcr.io/kaovilai/velero-plugin-for-aws:sdk-v2-loggingDev Notes
image build command