root: only set the schema version once, at the end

This avouds a bit of duplication.
vmiklos · Oct 4, 2024 · f1c1955 · f1c1955
1 parent 281b973
commit f1c1955
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/commands/root.go b/commands/root.go
@@ -181,15 +181,6 @@ func initDatabase(ctx *Context) error {
 		if err != nil {
 			return fmt.Errorf("db.Exec() failed: %s", err)
 		}
-
-		query, err = ctx.Database.Prepare("pragma user_version = 1")
-		if err != nil {
-			return fmt.Errorf("db.Prepare() failed: %s", err)
-		}
-		_, err = query.Exec()
-		if err != nil {
-			return fmt.Errorf("db.Exec() failed: %s", err)
-		}
 		ctx.DatabaseMigrated = true
 	}
 
@@ -203,16 +194,18 @@ func initDatabase(ctx *Context) error {
 		if err != nil {
 			return fmt.Errorf("db.Exec() failed: %s", err)
 		}
+		ctx.DatabaseMigrated = true
+	}
 
-		query, err = ctx.Database.Prepare("pragma user_version = 2")
+	if ctx.DatabaseMigrated {
+		query, err := ctx.Database.Prepare("pragma user_version = 2")
 		if err != nil {
 			return fmt.Errorf("db.Prepare() failed: %s", err)
 		}
 		_, err = query.Exec()
 		if err != nil {
 			return fmt.Errorf("db.Exec() failed: %s", err)
 		}
-		ctx.DatabaseMigrated = true
 	}
 
 	return nil