Redraw window at regular intervals not a fixed time after last move #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, each redraw would start a timer before the update took place. Each time a new event came, the timer would be reset. This means the update can be indefinitely delayed by a long sequence of events. Instead, only set the timer if it doesn't exist, so an update is guaranteed to happen at regular intervals, rather than waiting for a pause in the event stream. This avoids lags, e.g. when fractional scaling is used on Wayland.
|
Apologies for the delay, I thought I had done something with this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that with fractional scaling on Wayland scrolling with the trackpad became very laggy. This pull request fixes that. Hopefully in a reasonable way.
Previously, each redraw would start a timer before the update took place. Each time a new event came, the timer would be reset. This means the update can be indefinitely delayed by a long sequence of events.
Instead, only set the timer if it doesn't exist, so an update is guaranteed to happen at regular intervals, rather than waiting for a pause in the event stream.