Securize: Increase isolation by stripping away prototypes #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we assign our new `(secured-eval)` we've been allowing the `window`
property to bleed through as `this`. Additionally we have been setting
our forbidden symbols as the empty object `{}` which also exposes the
`Object` prototype.
In this patch we're replacing both of those in an attempt to further
limit the extent to which scripts can access global data.
The downside to this approach is that we've lost all prototypes that we
want, such as `Array.prototype.map`. The severity of this limitation is
so high that it's probably unmergable, but I'm hoping there might still
be a way to resolve that.
dmsnell
commented
Sep 25, 2019
| (set! eval-in-global-scope js/eval) | ||
| (j/assoc! js/window :klipse_unsecured_eval original-eval) | ||
| (j/assoc! js/window :klipse_eval_sandbox (clj->js (zipmap the-forbidden-symbols (repeat {})))) | ||
| (j/assoc! js/window :klipse_eval_sandbox (clj->js (zipmap the-forbidden-symbols (repeat (js/Object.create nil))))) |
There was a problem hiding this comment.
@viebel I think this one makes sense on its own as a change; I'm not entirely sure of the security implications though it does unhinge the forbidden symbols from the Object and Function prototypes…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: DO NOT MERGE
See #247
See #339
When we assign our new
(secured-eval)we've been allowing thewindowproperty to bleed through as
this. Additionally we have been settingour forbidden symbols as the empty object
{}which also exposes theObjectprototype.In this patch we're replacing both of those in an attempt to further
limit the extent to which scripts can access global data.
The downside to this approach is that we've lost all prototypes that we
want, such as
Array.prototype.map. The severity of this limitation isso high that it's probably unmergable, but I'm hoping there might still
be a way to resolve that.