Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-7904] Remove status from components #4461

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

randhid
Copy link
Member

@randhid randhid commented Oct 18, 2024

Since this API is deprecated, I am doing some cleaning and removing it from component registrations.
Manually tested with a Mac viam-server and fake components that change their state, control card still works.
This breaks the local rc card, so I may wait until that is updated until I merge this.

Still to do:

  • Manual tests on a raspberry pi.

@randhid randhid requested a review from cheukt October 18, 2024 14:36
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
motion GetPose
vision GetProperties

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 18, 2024
@cheukt
Copy link
Member

cheukt commented Oct 18, 2024

ya we should only remove it when local rc no longer relies on this

@randhid
Copy link
Member Author

randhid commented Nov 5, 2024

Waiting on #4520 to be merged in.

@randhid randhid force-pushed the 20241017-remove-status-from-components branch from 69f606c to 34ee30f Compare November 22, 2024 20:06
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 22, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 22, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 26, 2024
@cheukt
Copy link
Member

cheukt commented Nov 26, 2024

are we removing it in the api repo too?

@randhid
Copy link
Member Author

randhid commented Nov 26, 2024

are we removing it in the api repo too?

Not in this pr, I don't want to do an API break - that's too much sdk work plus I have no clue if you guys still use last_reconfigured from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants