-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-7904] Remove status from components #4461
base: main
Are you sure you want to change the base?
[RSDK-7904] Remove status from components #4461
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
ya we should only remove it when local rc no longer relies on this |
Waiting on #4520 to be merged in. |
69f606c
to
34ee30f
Compare
are we removing it in the api repo too? |
Not in this pr, I don't want to do an API break - that's too much sdk work plus I have no clue if you guys still use last_reconfigured from it. |
Since this API is deprecated, I am doing some cleaning and removing it from component registrations.
Manually tested with a Mac viam-server and fake components that change their state, control card still works.
This breaks the local rc card, so I may wait until that is updated until I merge this.
Still to do: