Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-3311 - Remove data field from TabularDataByMQL / SQL responses #589

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

dmhilly
Copy link
Member

@dmhilly dmhilly commented Nov 12, 2024

This PR removes the data field from the TabularDataByMQL + SQL responses. Users should use the raw_data field instead, which is already used by the Viam SDKs.

@github-actions github-actions bot added the safe to test committer is a member of this org label Nov 12, 2024
Copy link
Member

@katiepeters katiepeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine! How do you resolve the "Test For Lint and Breaking Changes"? Or do you not

@dmhilly dmhilly added the ready-for-protos add this when you want protos to compile on every commit label Nov 12, 2024
@dmhilly
Copy link
Member Author

dmhilly commented Nov 12, 2024

The changes look fine! How do you resolve the "Test For Lint and Breaking Changes"? Or do you not

Good question, the process for compiling the protos and merging is explained in the README here!

@dmhilly dmhilly removed the ready-for-protos add this when you want protos to compile on every commit label Nov 12, 2024
@stevebriskin stevebriskin merged commit 50a8a95 into viamrobotics:main Nov 12, 2024
2 of 3 checks passed
dmhilly added a commit to dmhilly/api that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants