Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-6845: Create GetBillingService API #588

Merged
merged 6 commits into from
Nov 12, 2024
Merged

APP-6845: Create GetBillingService API #588

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c906b0
APP-6845: Create GetBillingService API
jr22 Nov 11, 2024
8150276
roxy comments
jr22 Nov 11, 2024
d365c49
Revert "roxy comments"
jr22 Nov 11, 2024
f50591e
roxy comments
jr22 Nov 11, 2024
10dcd9d
Built new protos from f50591e
github-actions[bot] Nov 12, 2024
c428f8f
empty
jr22 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions proto/viam/app/v1/app.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ service AppService {

rpc UpdateBillingService(UpdateBillingServiceRequest) returns (UpdateBillingServiceResponse);

rpc GetBillingService(UpdateBillingServiceRequest) returns (UpdateBillingServiceResponse);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be GetBillingServiceConfig?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup I think that it should be


rpc OrganizationSetSupportEmail(OrganizationSetSupportEmailRequest) returns (OrganizationSetSupportEmailResponse);

rpc OrganizationGetSupportEmail(OrganizationGetSupportEmailRequest) returns (OrganizationGetSupportEmailResponse);
Expand Down Expand Up @@ -447,6 +449,14 @@ message UpdateBillingServiceRequest {

message UpdateBillingServiceResponse {}

message GetBillingServiceRequest {
string org_id = 1;
}

message GetBillingServiceResponse {
BillingAddress billing_address = 1;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RoxyFarhad what other fields are you picturing here? you listed a few in the ticket description but wanted to know what you included in the email

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from the email:

message GetBillingServiceConfigResponse {
  BillingAddress billing_address = 1; 
  string support_email = 2;
  string logo_url = 3;
  string billing_dashboard_url = 4; 
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated


message DisableBillingServiceRequest {
string org_id = 1;
}
Expand Down
Loading