Implement Dark Mode Support #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close vercel-labs#17 Co-Authored-By: ruru <[email protected]>
|
@ruru-m07 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
checks ✅
1. ✅
2. ✅
3. ✅
|
|
@jeremyphilemon can you review this pull request? |
athrael-soju
approved these changes
May 4, 2024
There was a problem hiding this comment.
This is great work. I've tested it and it works just fine. @jeremyphilemon can we get this reviewed please?
zvictor
reviewed
Aug 1, 2024
| @@ -63,7 +63,7 @@ export function ChatPanel({ | |||
| <div | |||
| key={example.heading} | |||
| className={cn( | |||
| 'cursor-pointer bg-zinc-50 text-zinc-950 rounded-2xl p-4 sm:p-6 hover:bg-zinc-100 transition-colors', | |||
| 'cursor-pointer bg-secondary rounded-2xl p-4 sm:p-6 transition-colors', | |||
There was a problem hiding this comment.
Suggested change
| 'cursor-pointer bg-secondary rounded-2xl p-4 sm:p-6 transition-colors', | |
| 'cursor-pointer bg-background rounded-2xl p-4 sm:p-6 transition-colors', |
you are removing the colour distinction of the button if not using something more distinct such as bg-background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request close #17
first i add
ThemeProviderafter this i see this UI
- this is too bad i make it batter now.
dark theme
light theme
