Removed useless metric dimensions

vapor · Aug 28, 2024 · a285407 · a285407
1 parent 8d9ee35
commit a285407
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/Sources/Queues/QueueWorker.swift b/Sources/Queues/QueueWorker.swift
@@ -126,20 +126,17 @@ public struct QueueWorker: Sendable {
         Timer(
             label: "\(id.string).jobDurationTimer",
             dimensions: [
-                ("success", "true"),
+                ("success", error == nil ? "true" : "false"),
                 ("id", id.string),
             ],
             preferredDisplayUnit: .seconds
         ).recordNanoseconds(DispatchTime.now().uptimeNanoseconds - startTime)
 
         // Adds the completed job to a different counter depending on its result
-        if let error = error {
+        if error != nil {
             Counter(
                 label: "error.completed.jobs.counter",
-                dimensions: [
-                    ("id", id.string),
-                    ("error", error.localizedDescription),
-                ]
+                dimensions: [("queueName", queue.queueName.string)]
             ).increment()
         } else {
             Counter(