Support GitHub access tokens and cache API results #337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #272 by authenticating with GitHub if the
GITHUB_ACCESS_TOKEN
environment variable is set.Notes
content
key which didn't exist. I added another configuration parameter to each source calleddecode_content
which specifies whether to attempt this decoding or not.To do (optional)
If we merge this PR, the following should either be fixed now or filed as issues to be addressed later.
I'd really like to add at least a few unit tests to this, at least for the stuff that's easy to test, but the unit test framework was added in Fix relative links in external markdown #336, which hasn't been merged yet.Filed as Add some unit tests for jekyll_get #346.GITHUB_ACCESS_TOKEN
, it will also speed up incremental builds by around 0.5 seconds. We should also document it in the readme so developers don't get confused if they notice stale data on their local server, and so they know how to clear the cache if needed.