AuthenticationMethodChooser 添加无参数构造函数 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the7thchakra
reviewed
Dec 6, 2021
| @@ -9,6 +10,10 @@ public class AuthenticationMethodChooser : IAuthenticationMethodChooser | |||
| private readonly IExternalEventWriter _eventWriter; | |||
| private IAuthenticator _innerMethod; | |||
|
|
|||
| public AuthenticationMethodChooser() | |||
There was a problem hiding this comment.
This would break the AWS authentication method.
I think a larger refactor may be necessary here, like
- Refactoring the
Authenticatemethod to accept anEventWriter; or - Refactoring the authentication method "chooser" types to act as factories to create the appropriate authenticator when
ActivateOptionsis called on the appender.
I think (1) is probably sufficient?
There was a problem hiding this comment.
Thanks for your contribution! really appreciate :)
Do you think you can implement the first method?
And regarding AWS authentication - does it break it for sure? I think I want to verify this before pushing this commit.
|
It would be great to have the fix merged if it resolves #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xml配置出错 无法创建授权方式