Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create docusaurus-json-schema-plugin.yml #4586

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

Create docusaurus-json-schema-plugin.yml #4586

wants to merge 4 commits into from

Conversation

jy95
Copy link

@jy95 jy95 commented Apr 20, 2024

No description provided.

@shiftbot
Copy link
Contributor

👋 I'm a robot checking the state of this pull request to save the human reviewers time. I noticed this PR added or modififed the data files under _data/projects/ so I had a look at what's changed.

As you make changes to this pull request, I'll re-run these checks.

_data/projects/docusaurus-json-schema-plugin.yml ❌

I couldn't find the label that was used in the upforgrabs.link value: 'up for grabs'. Please update the configuration to match the right label in this repository.

shiftkey
shiftkey reviewed Jul 15, 2024
View reviewed changes
_data/projects/docusaurus-json-schema-plugin.yml
- docusaurus
upforgrabs:
name: up for grabs
link: https://github.com/jy95/docusaurus-json-schema-plugin/discussions/categories/ideas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have support for a discussion category, but this is interesting to potentially support. Would need some plumbing changes to do a different query to compute the count...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the "top" sorting interesting for better community engagement

@shiftkey shiftkey added needs-engineering-work Tracking contributions that require core engineering work to be deployed as-is and removed needs review labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftkey shiftkey shiftkey left review comments

Assignees
No one assigned
Labels
needs-engineering-work Tracking contributions that require core engineering work to be deployed as-is
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jy95 @shiftbot @shiftkey