lib/posix-fdtab: Export fdtab init priority #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9dc2701 changed the fdtab init priority and removed the macro that exported it. `lib/devfs/` however uses the `fdtab` init priority to register it's own devices, calling `uk_rootfs_initcall_prio(..., UK_PRIO_AFTER(UK_LIBPOSIX_FDTAB_PRIO))`, resulting in the `devfs` devices not being registered at all. Reintroduce the macro used to export the fdtab init priority and set it to `UK_PRIO_EARLIEST`. Signed-off-by: Stefan Jumarea <[email protected]>
StefanJum
added
kind/bug
razvand
added
area/lib
razvand
approved these changes
Dec 31, 2023
There was a problem hiding this comment.
Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]
razvand
pushed a commit
that referenced
this pull request
Dec 31, 2023
Commit 9dc2701 changed the fdtab init priority and removed the macro that exported it. `lib/devfs/` however uses the `fdtab` init priority to register it's own devices, calling `uk_rootfs_initcall_prio(..., UK_PRIO_AFTER(UK_LIBPOSIX_FDTAB_PRIO))`, resulting in the `devfs` devices not being registered at all. Reintroduce the macro used to export the fdtab init priority and set it to `UK_PRIO_EARLIEST`. Signed-off-by: Stefan Jumarea <[email protected]> Approved-by: Razvan Deaconescu <[email protected]> Reviewed-by: Razvan Deaconescu <[email protected]> GitHub-Closes: #1231
This was referenced Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9dc2701 changed the fdtab init priority and removed the macro that exported it.
lib/devfs/however uses thefdtabinit priority to register it's own devices, callinguk_rootfs_initcall_prio(..., UK_PRIO_AFTER(UK_LIBPOSIX_FDTAB_PRIO)), resulting in thedevfsdevices not being registered at all.Reintroduce the macro used to export the fdtab init priority and set it to
UK_PRIO_EARLIEST.Prerequisite checklist
checkpatch.ukon your commit series before opening this PR;Additional configuration
You can see issue #31 on the catalog repo.
Adding this line
access_log /dev/stdout;in thenginxconfig file will lead to an error: