Add from_fixed_decimal method to construct CompactDecimal #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
changed the title
sffc
reviewed
Dec 3, 2024
| /// # | ||
| /// assert_eq!(CompactDecimal::from_fixed_decimal(SignedFixedDecimal::from_str("+1.20").unwrap()), CompactDecimal::from_str("+1.20").unwrap()); | ||
| /// ``` | ||
| pub fn from_fixed_decimal(fixed_decimal: SignedFixedDecimal) -> Self { |
There was a problem hiding this comment.
Question: why do we want this function when we already have from_significand_and_exponent?
There was a problem hiding this comment.
Yes, we do not need it.
I used format_fixed_decimal to format SignedFixedDecimal in the CompactFormatter.
See: #5456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.