Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dateSkeleton pattern lookup in datagen #5826

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sffc
Copy link
Member

@sffc sffc commented Nov 15, 2024

@sffc
Copy link
Member Author

sffc commented Nov 28, 2024

I need a suggestion involving how to drive @gregtatum's (non-semantic) skeleton API.

Currently I use a components::Bag as the intermediate type. This lets me do things like change the width of the year or set a custom hour cycle when performing skeleton selection.

This has been working fine, but today I discovered that it seems to mess up weekday patterns in a few locales such as fi where there is a difference between c and E. It seems that components::Bag will always look up E and not c.

The type Skeleton supports c vs E, but it has a much more limited API, as essentially only a list of fields.

Do you have a suggestion on how to drive the skeleton selection better?

@zbraniecki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant