chore: switch to official upstream images #687
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castrojo
reviewed
Dec 2, 2024
.github/workflows/reusable-build.yml
Outdated
Comment on lines
42
to
45
| - image_name: sericea | ||
| base_image: quay.io/fedora/fedora-sway-atomic | ||
| - image_name: onyx | ||
| base_image: quay.io/fedora/fedora-budgie-atomic |
There was a problem hiding this comment.
Should we just go with the upstream names so they end up being sway-main and budgie-main?
There was a problem hiding this comment.
We can do, though it may be best waiting for the next major version rather than introducing breaking changes in the middle of a cycle
|
I see |
dosubot
bot
added
the
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #669
This is fully backwards-compatible. Builds official images using the official Quay repository, but keeps building the unofficial images using the unofficial repository.
I have tested this with a Fedora 41 image, which worked exactly the same as before. I haven't tested with Fedora 40.