Updated whitenoise shader #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some time (±2 minutes), diagonal lines appeared on the shader. The suggested shader is much simpler and doesn't have this issue.
|
Thank you for this! Could you check that the function name and signature hasn't changed, and that it remains stitchable? I want to merge this in, but don't want to break backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of the white-noise shader had an issue where, after some time (approximately 2 minutes), diagonal lines appeared on the shader. The updated shader uses essentially the same formula but is a bit simpler and does not have this issue. It has been tested on both simulators and real devices.
Original:
Updated: