wip perplexity2 #21
Open
wip perplexity2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpan8866
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const escapeDollarSigns = (text: string | undefined) => { | ||
| if (!text) return "Aider response over"; | ||
| return text.replace(/\$/g, "\\$"); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 11 hours ago
To fix the problem, we need to ensure that backslashes are also escaped in the escapeDollarSigns function. This can be achieved by first replacing backslashes with double backslashes and then replacing dollar signs with escaped dollar signs. This ensures that both backslashes and dollar signs are properly escaped.
- Modify the
escapeDollarSignsfunction to handle backslashes by adding an additional replace operation. - Ensure that the function uses regular expressions with the
gflag to replace all occurrences of the characters.
Suggested changeset
1
core/llm/llms/Aider.ts
| @@ -345,3 +345,3 @@ | ||
| if (!text) return "Aider response over"; | ||
| return text.replace(/\$/g, "\\$"); | ||
| return text.replace(/\\/g, "\\\\").replace(/\$/g, "\\$"); | ||
| }; |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✏️
Closes #xxx
What changed? Feel free to be brief.
Checklist ✅