Merge pull request #7 from IgorFroehner/IgorFroehner/fix-when-retry-c…

…ount-is-not-present

fix: consider zero when retry_count not present

lib/sidekiq/silent_retry/server_middleware.rb

@@ -17,7 +17,7 @@ def call(_job_instance, job_payload, _queue)
       private
 
       def should_warn?(job_payload)
-        job_payload["retry_count"] >= warn_after(job_payload)
+        (job_payload["retry_count"] || 0) >= warn_after(job_payload)
       end
 
       def warn_after(job_payload)

spec/sidekiq/silent_retry/server_middleware_spec.rb

@@ -17,6 +17,31 @@
     }
   end
 
+  context 'in the first failure' do
+    let(:job_payload) do
+      {
+        "retry" => 2,
+        "silent_retry" => silent_retry
+      }
+    end
+
+    context 'with silent retry enabled' do
+      let(:silent_retry) { true }
+
+      it 'raises the silent error' do
+        expect { subject }.to raise_error(Sidekiq::SilentRetry.silent_retry_error_class, "some message")
+      end
+    end
+
+    context 'with silent retry disabled' do
+      let(:silent_retry) { false }
+
+      it 'raises the error' do
+        expect { subject }.to raise_error(StandardError, "some message")
+      end
+    end
+  end
+
   context "when silent retry is off" do
     let(:silent_retry) { false }