refactor: Introduce 'id' prop on <Tooltip> #2562
Open
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This commit introduces a required 'id' property on the <Tooltip> component which replaces the random automatcially generated one used previously.
ClayBenson94
requested review from
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
|
@ClayBenson94 Hey - that use case makes a lot sense to me! In terms of implementation - can we surface the |
|
@ClayBenson94 do you have some time to make the change Hana suggested? ☝️ |
shkeating
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit introduces a required 'id' property on the
component which replaces the random automatically generated one used previously.
Our application creates snapshot tests using
jest-snapshot, and the randomly-generated IDs that come from this component make the snapshots no longer deterministic (and would fail on each run).This PR is an attempt to address that. I can't say I'm in love with this solution as it does introduce a breaking change that would require IDs to be placed on
<Tooltip>components across the board, so I am open to other solutions as well!Related Issues or PRs
How To Test
Screenshots (optional)