Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #24246

Merged
merged 7 commits into from
Nov 25, 2024
+23 −30
Merged

Update dependencies #24246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7d1756
Update zstd-jni to 1.5.6-8
wendigo Nov 24, 2024
6404d06
Update log4j-api to 2.24.2
wendigo Nov 24, 2024
c1e8870
Update flyway to 11.0.0
wendigo Nov 24, 2024
277fc21
Update AWS SDK v2 to 2.29.20
wendigo Nov 24, 2024
4f0020d
Update ranger dependencies
wendigo Nov 25, 2024
2a1727a
Update exasol testcontainers to 7.1.2
wendigo Nov 25, 2024
ce093e2
Use switch statement
wendigo Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions plugin/trino-apache-ranger/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<description>Trino - Apache Ranger access control</description>

<properties>
<dep.graalvm.version>24.1.0</dep.graalvm.version>
<dep.graalvm.version>24.1.1</dep.graalvm.version>
<dep.ranger.version>2.5.0</dep.ranger.version>
</properties>

Expand Down Expand Up @@ -106,7 +106,7 @@
<dependency>
<groupId>com.carrotsearch</groupId>
<artifactId>hppc</artifactId>
<version>0.8.1</version>
<version>0.10.0</version>
<scope>runtime</scope>
</dependency>

Expand All @@ -126,7 +126,7 @@
<dependency>
<groupId>org.apache.hadoop.thirdparty</groupId>
<artifactId>hadoop-shaded-guava</artifactId>
<version>1.2.0</version>
<version>1.3.0</version>
<scope>runtime</scope>
</dependency>

Expand Down Expand Up @@ -198,6 +198,13 @@
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>org.graalvm.sdk</groupId>
<artifactId>nativeimage</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @kokosing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an upper bound resolution. This dependency was already there

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC: @mneethiraj

<version>${dep.graalvm.version}</version>
<scope>runtime</scope>
</dependency>

<dependency>
<groupId>org.graalvm.truffle</groupId>
<artifactId>truffle-api</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-exasol/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
<dependency>
<groupId>com.exasol</groupId>
<artifactId>exasol-testcontainers</artifactId>
<version>7.1.1</version>
<version>7.1.2</version>
wendigo marked this conversation as resolved.
Show resolved Hide resolved
<scope>test</scope>
</dependency>

Expand Down
30 changes: 8 additions & 22 deletions ...o-singlestore/src/test/java/io/trino/plugin/singlestore/TestSingleStoreConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,34 +115,20 @@ protected Optional<DataMappingTestSetup> filterDataMappingSmokeTestData(DataMapp
{
String typeName = dataMappingTestSetup.getTrinoTypeName();

wendigo marked this conversation as resolved.
Show resolved Hide resolved
if (typeName.equals("boolean")) {
return switch (typeName) {
wendigo marked this conversation as resolved.
Show resolved Hide resolved
// SingleStore does not have built-in support for boolean type. SingleStore provides BOOLEAN as the synonym of TINYINT(1)
// Querying the column with a boolean predicate subsequently fails with "Cannot apply operator: tinyint = boolean"
return Optional.empty();
}

if (typeName.equals("time")) {
case "boolean" -> Optional.empty();
// SingleStore supports only second precision
// Skip 'time' that is alias of time(3) here and add test cases in TestSingleStoreTypeMapping.testTime instead
return Optional.empty();
}

if (typeName.equals("timestamp(3) with time zone") ||
typeName.equals("timestamp(6) with time zone")) {
return Optional.of(dataMappingTestSetup.asUnsupported());
}

if (typeName.equals("timestamp")) {
case "time" -> Optional.empty();
case "timestamp(3) with time zone", "timestamp(6) with time zone" -> Optional.of(dataMappingTestSetup.asUnsupported());
// TODO this should either work or fail cleanly
return Optional.empty();
}

if (typeName.equals("varchar")) {
case "timestamp" -> Optional.empty();
// TODO fails due to case insensitive UTF-8 comparisons
return Optional.empty();
}

return Optional.of(dataMappingTestSetup);
case "varchar" -> Optional.empty();
default -> Optional.of(dataMappingTestSetup);
};
}

@Test
Expand Down
8 changes: 4 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@
<dep.confluent.version>7.7.1</dep.confluent.version>
<dep.docker.images.version>102</dep.docker.images.version>
<dep.drift.version>1.22</dep.drift.version>
<dep.flyway.version>10.22.0</dep.flyway.version>
<dep.flyway.version>11.0.0</dep.flyway.version>
wendigo marked this conversation as resolved.
Show resolved Hide resolved
<dep.frontend-maven-plugin.version>1.15.1</dep.frontend-maven-plugin.version>
<dep.frontend-node.version>v22.11.0</dep.frontend-node.version>
<dep.frontend-npm.version>10.9.0</dep.frontend-npm.version>
Expand Down Expand Up @@ -311,7 +311,7 @@
<dependency>
<groupId>software.amazon.awssdk</groupId>
<artifactId>bom</artifactId>
<version>2.29.18</version>
<version>2.29.20</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -504,7 +504,7 @@
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
<version>1.5.6-7</version>
<version>1.5.6-8</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -2038,7 +2038,7 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-api</artifactId>
<version>2.24.1</version>
<version>2.24.2</version>
</dependency>

<dependency>
Expand Down
Loading