Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial aggregation pushdown support for Vertica #24234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vlad-lyutenko
Copy link
Contributor

@vlad-lyutenko vlad-lyutenko commented Nov 22, 2024

Description

Adding some aggregation pushdowns, except

  • STDDEV and VARIANCE, because in case of situation when function can not be computed (like single value), Vertica returns NaN, but trino returns Null, so to be in line with trino we disable these types of pushdowns for now.
  • avg pushdown for decimal values, because, when Vertica cast values to decimal value with some scale, instead of rounding, it just truncate it, but trino rounds values.

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/vertica-aggregation-pushdown branch 3 times, most recently from 521f1d4 to 8b0bf4c Compare November 25, 2024 15:00
@vlad-lyutenko vlad-lyutenko force-pushed the vlad-lyutenko/vertica-aggregation-pushdown branch from 8b0bf4c to 60c9f4e Compare November 25, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant