Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tip warning the developers that they may have bridge disabled in the debug settings #15616

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add tip warning the developers that they may have bridge disabled in the debug settings #15616

wants to merge 1 commit into from
+62 −17

Conversation

peter-sanderson
Copy link
Contributor

@peter-sanderson peter-sanderson commented Nov 27, 2024 •
edited
Loading

  • Tip shows only if you have debug mode on + disabled both bridge and legacy bridge

image

mroz22
mroz22 requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please test web.

and this..

&& !bridgeSettings?.legacy

is it needed? I am not sure I get why

@peter-sanderson peter-sanderson force-pushed the add-tip-for-debug branch 4 times, most recently from 000352b to 66144e3 Compare December 2, 2024 14:29
@peter-sanderson peter-sanderson enabled auto-merge (rebase) December 2, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroz22 mroz22 mroz22 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-sanderson @mroz22