feat(connect): all backupDevice and recoveryDevice even for devices w… #15599
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
mroz22
force-pushed
the
connect-allow-backup-and-recovery
branch
from
ec92b33
to
7bb240c
Compare
mroz22
commented
Nov 27, 2024
| @@ -156,7 +156,7 @@ export const connectInitThunk = createThunk( | |||
| pendingTransportEvent: selectIsPendingTransportEvent(getState()), | |||
| transports: selectDebugSettings(getState()).transports, | |||
| _sessionsBackgroundUrl, | |||
| // debug: true, // Enable debug logs in TrezorConnect | |||
| debug: true, // Enable debug logs in TrezorConnect | |||
komret
approved these changes
Dec 2, 2024
…ithh required firmware update fix: UI for T1 vs other Devices
peter-sanderson
force-pushed
the
connect-allow-backup-and-recovery
branch
from
bdca709
to
aac3c27
Compare
peter-sanderson
requested review from
szymonlesisz,
martykan and
marekrjpolak
as code owners
peter-sanderson
approved these changes
Dec 2, 2024
Lemonexe
reviewed
Dec 2, 2024
| ); | ||
| // Do not rely on Capability_PassphraseEntry feature. For ancient firmwares it's not there, | ||
| // and we want to allow devices that have unsupported FW to be able to check the seed. | ||
| if (device.features.internal_model === DeviceModelInternal.T1B1) { |
There was a problem hiding this comment.
👍 I mindlessly copied old code, this makes much more sense 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith required firmware update
cc @MiroslavProchazka
test device:
T&2.1.8(first lower thenrequired: true