Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Draft: Make 'file_format' optional #219

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aaronsteers
Copy link

@aaronsteers aaronsteers commented Oct 15, 2021

Problem

WIP. Resolves #188

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@aaronsteers aaronsteers marked this pull request as draft October 15, 2021 18:03
@aaronsteers
Copy link
Author

@koszti - I have a start here but I haven't tested yet. Do you mind enabling the CI workflow for this pipeline? Thanks!

@koszti
Copy link
Contributor

koszti commented Oct 16, 2021

@koszti - I have a start here but I haven't tested yet. Do you mind enabling the CI workflow for this pipeline? Thanks!

Enabled. Please note that only the unit tests will run from your PR. Integration tests require a snowflake instance that's not available for PRs from forked repos. Can you please run integration tests locally by setting the env vars that defined here and point to your snowflake account?

@koszti koszti marked this pull request as ready for review October 19, 2021 07:55
@koszti koszti marked this pull request as draft October 19, 2021 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pre-created FILE_FORMAT object optional
2 participants