Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types) - add children for Marker, GoogleMaps, InfoWindow #1095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(types) - add children for Marker, GoogleMaps, InfoWindow #1095

wants to merge 1 commit into from

Conversation

mikan-sour
Copy link

@mikan-sour mikan-sour commented Nov 7, 2022 •
edited
Loading

PLEASE CHECK "Allow edits from maintainers"

help

FOLLOW "Conventional Commits Specification" FOR ALL COMMITS

https://conventionalcommits.org/

@mikan-sour
Copy link
Author

Background

I am using Typescript 4.8.4 and getting a type error when trying to use Marker and InfoWindow as children of the GoogleMap component.

Fix

Add children as an optional prop of type ReactNode to the interfaces for these components.

Additional

Please feel free to make a suggestion for how to better fix or how to change my code as to not need to apply this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikan-sour