Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation inside virtual env #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

blokhin
Copy link
Member

@blokhin blokhin commented Jul 6, 2022

otherwise the Python is taken from /usr/bin/python which can lead to some weird import problems

@blokhin blokhin requested review from ansobolev and irygaev July 6, 2022 13:50
@blokhin
Copy link
Member Author

blokhin commented Nov 11, 2022

/prbot describe


if (PYTHON)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine; however, what if a user does not have Python installed on the system? Previously the build system worked in such a way that factpp was able to be built from the root directory even if Python bindings were not needed. However, this PR makes it impossible. If you are OK with that, feel free to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants