Figure changes for print version #231
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@topepo I think there is still one figure in here that text got changed for but no new code was written. I couldn't quite get what you had planned based on only the text so I'm hoping you either know or have the code somewhere. It is the current Fig 13.9 here. |
Merged
juliasilge
added a commit
that referenced
this pull request
Feb 4, 2022
Merge branch 'main' into figs-for-print # Conflicts: # 12-tuning-parameters.Rmd
Closed
Merge branch 'main' into figs-for-print # Conflicts: # 14-iterative-search.Rmd
Merge branch 'main' into figs-for-print # Conflicts: # 13-grid-search.Rmd
…nto figs-for-print
Merge branch 'main' into figs-for-print # Conflicts: # index.Rmd
Merge branch 'main' into figs-for-print # Conflicts: # 18-explaining-models-and-predictions.Rmd
Merge branch 'main' into figs-for-print # Conflicts: # 04-ames.Rmd # 06-fitting-models.Rmd # 07-the-model-workflow.Rmd # 08-feature-engineering.Rmd # 10-resampling.Rmd # 12-tuning-parameters.Rmd # 13-grid-search.Rmd # 16-dimensionality-reduction.Rmd # 17-encoding-categorical-data.Rmd # 18-explaining-models-and-predictions.Rmd # 19-when-should-you-trust-predictions.Rmd # 20-ensemble-models.Rmd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215
This PR (which we will not merge into the main branch) contains the rest of the figure changes for printing in grayscale. I found more changes that I do want to integrate into the website so I'll do another PR, merge it, and merge main back into this branch after we make some of the other changes.
Still to be done are the figures outlined in #212; some of those should go into the main branch and some shouldn't.