Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Unpaywall response when article has "avoidUnpaywallPublisherLinks" set to true and host_type is "publisher" - bz 8727 #138

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Ignore Unpaywall response when article has "avoidUnpaywallPublisherLinks" set to true and host_type is "publisher" - bz 8727 #138

wants to merge 6 commits into from
+93 −27

Commits on Nov 27, 2024

  1. Ignore vscode settings file

    @karlbecker
    karlbecker committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e10108b View commit details
    Browse the repository at this point in the history

  2. Avoid using unpaywall response when host_type is publisher

    @karlbecker
    karlbecker committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ace5cda View commit details
    Browse the repository at this point in the history

  3. Eliminate avoidUnpaywallPublisherLinks from shouldAvoidUnpaywall 

    We'll only look at that after the Unpaywall call is made
    @karlbecker
    karlbecker committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    5a411fb View commit details
    Browse the repository at this point in the history

  4. Modify tests to ensure unpaywall response with host_type of publisher… 

    … does not result in enhancing a search result for Primo or Summon
    @karlbecker
    karlbecker committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    ece6ff1 View commit details
    Browse the repository at this point in the history

  5. Comment out functionality to ensure tests fail in CI

    @karlbecker
    karlbecker committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    20a153c View commit details
    Browse the repository at this point in the history

  6. Ensure Unpaywall responses with host_type of publisher is ignored whe… 

    …n Third Iron API says avoidUnpaywallPublisherLinks
    @karlbecker
    karlbecker committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    411c5af View commit details
    Browse the repository at this point in the history