Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thiagospiff #257

Open
wants to merge 72 commits into
base: master
Choose a base branch
from
Open

Thiagospiff #257

wants to merge 72 commits into from

Conversation

reynoldsalec
Copy link
Member

Trying this here to see if the Platform PR build works.

@reynoldsalec
Copy link
Member Author

Hey @thiagodemellobueno, glad to have you back on the scene!

Merged things over here because I was worried your cross-repo PR was causing P.sh build issues, but it turned out to just be linting fun 🙄

Let's chat about this, definitely some of our priorities have changed so we should reconnect around that and see what we want to do with the work in progress so far.

@thiagodemellobueno
Copy link

👍
Linting has gotten really intense of late in our multi - language multi package world.
Glad to chat at your convenience.

thiagodemellobueno and others added 29 commits January 27, 2021 19:05
Case study wranglign of half col titles, and a few bits of alignment …
@reynoldsalec
Copy link
Member Author

Couple things that are blocking merge right now (@thiagodemellobueno you're off the hook on these, appreciate you going the extra mile to clean up the other stuff, we can chat on Slack about setting you up with a budget to fix these up if you're interested).

Blog List Page

  • List view items are out-of-whack; see positioning of the author portrait (note this is also a problem on individual blog posts).
  • Go back to the big tags?
  • Link blog titles.

Blog Article Page

  • "Learn More About" tags list has black background. (very bottom of page)
  • Subscribe form needs attention (button sizing compared to form field)

Contact Page

  • Differences in the form button sizes/text style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants