-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thiagospiff #257
base: master
Are you sure you want to change the base?
Thiagospiff #257
Conversation
A couple convenience
Custom block and custom block title A little redundancy removal re {displayType} A little DRY work where it helps remove / organize code more better
State should be tracked in js, and classes used to swtich style, writing styles in html mucks things up. If you plan to introduce section colors in the future, then manipulate classes in the html, dont dynamically generate styles.
Work grid bits,
Hey @thiagodemellobueno, glad to have you back on the scene! Merged things over here because I was worried your cross-repo PR was causing P.sh build issues, but it turned out to just be linting fun 🙄 Let's chat about this, definitely some of our priorities have changed so we should reconnect around that and see what we want to do with the work in progress so far. |
👍 |
…ack up to top, rather than pageload.
…and padding polish.
Case study wranglign of half col titles, and a few bits of alignment …
Couple things that are blocking merge right now (@thiagodemellobueno you're off the hook on these, appreciate you going the extra mile to clean up the other stuff, we can chat on Slack about setting you up with a budget to fix these up if you're interested). Blog List Page
Blog Article Page
Contact Page
|
Trying this here to see if the Platform PR build works.