Fix key files permission on Windows #1447
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hafezdivandari
commented
Sep 26, 2024
| @@ -29,7 +29,7 @@ jobs: | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: ${{ matrix.php }} | |||
| extensions: dom, curl, libxml, mbstring, zip | |||
| extensions: dom, curl, libxml, mbstring, sodium, zip | |||
There was a problem hiding this comment.
sodium is not enabled on Windows by default, it is required by lcobucci/jwt package.
| self::assertSame($permission, decoct(fileperms(__DIR__ . '/Stubs/public.key') & 0777)); | ||
| self::assertSame($permission, decoct(fileperms(__DIR__ . '/Stubs/private.key.crlf') & 0777)); | ||
| } | ||
|
|
There was a problem hiding this comment.
You may delete this test, I added this to prove the difference on Windows only!
| @@ -72,7 +72,7 @@ public function __construct(string $keyPath, protected ?string $passPhrase = nul | |||
| throw new LogicException('Invalid key supplied'); | |||
| } | |||
|
|
|||
| if ($keyPermissionsCheck === true) { | |||
| if ($keyPermissionsCheck === true && PHP_OS_FAMILY !== 'Windows') { | |||
There was a problem hiding this comment.
Ignore key permissions check on Windows, as it always will be '666' or '444'.
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #901
Related to laravel/passport#1789
This PR adds windows tests and fixes the permission check on Windows. The possible file permissions on Windows are '666' and '444'.