Expand public spec APIs, fix FilterSelector string #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `spec.Filter.Eval` to allow public evaluation of a single JSON
node. Used internally by `spec.FilterSelector.Select`.
* Add `spec.Segment.IsDescendant` to tell wether a segments selects
just from the current child node or also recursively selects from
all of its descendants.
* Make `spec.SliceSelector.Bounds` public.
* Make the underlying struct defining `spec.Wildcard` public with the
name `spec.WildcardSelector`.
Other changes:
* Add missing "?" to the stringification of `spec.FilterSelector`.
* Upgrade to `golangci-lint` v1.62 and disable `gosec` G602 false
positives (securego/gosec#1250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec.Filter.Evalto allow public evaluation of a single JSON node. Used internally byspec.FilterSelector.Select.spec.Segment.IsDescendantto tell wether a segments selects just from the current child node or also recursively selects from all of its descendants.spec.SliceSelector.Boundspublic.spec.Wildcardpublic with the namespec.WildcardSelector.Other changes:
spec.FilterSelector.golangci-lintv1.62 and disablegosecG602 false positives (False Positive for G602 with bounds check using switch securego/gosec#1250)