Fix FilterSelector stringification

CHANGELOG.md

@@ -17,6 +17,10 @@ All notable changes to this project will be documented in this file. It uses the
     from the current child node or also recursively selects from all of its
     descendants.
 
+### 🪲 Bug Fixes
+
+*   Added missing "?" to the stringification of `spec.FilterSelector`.
+
 ### 📔 Notes
 
 *   Made `spec.SliceSelector.Bounds` public.

spec/selector.go

@@ -295,6 +295,7 @@ func (f *FilterSelector) String() string {
 
 // writeTo writes a string representation of f to buf.
 func (f *FilterSelector) writeTo(buf *strings.Builder) {
+	buf.WriteRune('?')
 	f.LogicalOr.writeTo(buf)
 }
 

spec/selector_test.go

@@ -543,7 +543,7 @@ func TestFilterSelector(t *testing.T) {
 			name:   "no_filter",
 			filter: Filter(LogicalOr{}),
 			exp:    []any{},
-			str:    "",
+			str:    "?",
 		},
 		{
 			name: "array_root",
@@ -553,7 +553,7 @@ func TestFilterSelector(t *testing.T) {
 			root:    []any{42, true, "hi"},
 			current: map[string]any{"x": 2},
 			exp:     []any{2},
-			str:     `$[0]`,
+			str:     `?$[0]`,
 		},
 		{
 			name: "array_root_false",
@@ -563,7 +563,7 @@ func TestFilterSelector(t *testing.T) {
 			root:    []any{42, true, "hi"},
 			current: map[string]any{"x": 2},
 			exp:     []any{},
-			str:     `$[4]`,
+			str:     `?$[4]`,
 		},
 		{
 			name: "object_root",
@@ -573,7 +573,7 @@ func TestFilterSelector(t *testing.T) {
 			root:    map[string]any{"x": 42, "y": "hi"},
 			current: map[string]any{"a": 2, "b": 3},
 			exp:     []any{2, 3},
-			str:     `$["y"]`,
+			str:     `?$["y"]`,
 			rand:    true,
 		},
 		{
@@ -584,7 +584,7 @@ func TestFilterSelector(t *testing.T) {
 			root:    map[string]any{"x": 42, "y": "hi"},
 			current: map[string]any{"a": 2, "b": 3},
 			exp:     []any{},
-			str:     `$["z"]`,
+			str:     `?$["z"]`,
 			rand:    true,
 		},
 		{
@@ -594,7 +594,7 @@ func TestFilterSelector(t *testing.T) {
 			}}}),
 			current: []any{[]any{42}},
 			exp:     []any{[]any{42}},
-			str:     `@[0]`,
+			str:     `?@[0]`,
 		},
 		{
 			name: "array_current_false",
@@ -603,7 +603,7 @@ func TestFilterSelector(t *testing.T) {
 			}}}),
 			current: []any{[]any{42}},
 			exp:     []any{},
-			str:     `@[1]`,
+			str:     `?@[1]`,
 		},
 		{
 			name: "object_current",
@@ -612,7 +612,7 @@ func TestFilterSelector(t *testing.T) {
 			}}}),
 			current: []any{map[string]any{"x": 42}},
 			exp:     []any{map[string]any{"x": 42}},
-			str:     `@["x"]`,
+			str:     `?@["x"]`,
 		},
 		{
 			name: "object_current_false",
@@ -621,7 +621,7 @@ func TestFilterSelector(t *testing.T) {
 			}}}),
 			current: []any{map[string]any{"x": 42}},
 			exp:     []any{},
-			str:     `@["y"]`,
+			str:     `?@["y"]`,
 		},
 	} {
 		t.Run(tc.name, func(t *testing.T) {