Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/blacklist #83

Merged
merged 35 commits into from
Jun 23, 2024
Merged

Feat/blacklist #83

merged 35 commits into from
Jun 23, 2024

Conversation

reifocS
Copy link
Contributor

@reifocS reifocS commented Jan 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (912614d) to head (079df6b).
Report is 3 commits behind head on master.

Current head 079df6b differs from pull request most recent head 4d65211

Please upload reports for the commit 4d65211 to get more accurate results.

Files Patch % Lines
...kotlin/com/sipios/springsearch/QueryVisitorImpl.kt 83.33% 1 Missing and 1 partial ⚠️
.../sipios/springsearch/strategies/BooleanStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...com/sipios/springsearch/strategies/DateStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...m/sipios/springsearch/strategies/DoubleStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...sipios/springsearch/strategies/DurationStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
.../sipios/springsearch/strategies/InstantStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
.../com/sipios/springsearch/strategies/IntStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...ipios/springsearch/strategies/LocalDateStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...s/springsearch/strategies/LocalDateTimeStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
...ipios/springsearch/strategies/LocalTimeStrategy.kt 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
- Coverage     83.00%   82.30%   -0.71%     
- Complexity      123      131       +8     
============================================
  Files            22       22              
  Lines           306      339      +33     
  Branches         43       51       +8     
============================================
+ Hits            254      279      +25     
+ Misses           28       27       -1     
- Partials         24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reifocS reifocS marked this pull request as ready for review May 6, 2024 13:46
@reifocS reifocS changed the base branch from feat/is-null to master June 20, 2024 14:54
Copy link

⚡ Coverage report

Overall Project 85.68% 🍏
Files changed 100% 🍏

File Coverage
QueryVisitorImpl.kt 97.14% 🍏

@phmz phmz merged commit 0b8d21c into master Jun 23, 2024
1 check passed
@phmz phmz deleted the feat/blacklist branch June 23, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants