Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Commit

Permalink
update rubocop to 0.72.0
Browse files Browse the repository at this point in the history
  • Loading branch information
mmoll committed Jun 30, 2019
1 parent 717923b commit 347f99f
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 45 deletions.
4 changes: 4 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
require:
- rubocop-performance
- rubocop-rails

inherit_from:
- .rubocop_todo.yml

Expand Down
50 changes: 6 additions & 44 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2018-11-11 15:08:09 +0100 using RuboCop version 0.60.0.
# on 2019-06-30 14:26:46 +0200 using RuboCop version 0.72.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 2
# Configuration parameters: AllowComments.
Lint/HandleExceptions:
Exclude:
- 'lib/foreman_xen/vnc_tunnel.rb'
Expand All @@ -23,69 +24,30 @@ Lint/UnusedBlockArgument:
Exclude:
- 'lib/foreman_xen/engine.rb'

# Offense count: 2
# Offense count: 1
# Cop supports --auto-correct.
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
Lint/UnusedMethodArgument:
Exclude:
- 'app/models/concerns/fog_extensions/xenserver/server.rb'
- 'app/models/foreman_xen/xenserver.rb'

# Offense count: 5
# Offense count: 4
Lint/UselessAssignment:
Exclude:
- 'app/helpers/xen_compute_helper.rb'
- 'lib/foreman_xen/vnc_tunnel.rb'

# Offense count: 16
Metrics/AbcSize:
Max: 67

# Offense count: 1
# Configuration parameters: CountBlocks.
Metrics/BlockNesting:
Max: 4

# Offense count: 2
# Configuration parameters: CountComments.
Metrics/ClassLength:
Max: 367

# Offense count: 3
Metrics/CyclomaticComplexity:
Max: 12

# Offense count: 21
# Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength:
Max: 52

# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ModuleLength:
Max: 111

# Offense count: 1
# Configuration parameters: CountKeywordArgs.
Metrics/ParameterLists:
Max: 6

# Offense count: 4
Metrics/PerceivedComplexity:
Max: 13

# Offense count: 4
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: io, id, to, by, on, in, at, ip, db
Naming/UncommunicativeMethodParamName:
Exclude:
- 'app/helpers/xen_compute_helper.rb'
- 'app/models/foreman_xen/xenserver.rb'

# Offense count: 19
# Offense count: 23
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: when_needed, always, never
# SupportedStyles: always, never
Style/FrozenStringLiteralComment:
Enabled: false

Expand Down
4 changes: 3 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ source 'https://rubygems.org'

gemspec

gem 'rubocop', '~> 0.60.0', require: false
gem 'rubocop', '~> 0.72.0', require: false
gem 'rubocop-performance', '~> 1.4.0', require: false
gem 'rubocop-rails', '~> 2.1.0', require: false

0 comments on commit 347f99f

Please sign in to comment.