Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: range input styling on gecko based browsers #98

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

willhack
Copy link
Contributor

@willhack willhack commented Nov 9, 2024

Does what it says on the tin!

This PR aims to fix styling issues described in this issue, namely that on gecko based browser like firefox, the range input track styling is not being applied. It makes it a bit difficult to realize that those are actually sliders.

Two other small changes:

  • firefox adds a gross border to the range thumb, so went ahead and removed that.
  • the border radius looked a little chonky so I turned it back into a circle

Expected (chrome):

Actual (firefox):

Firefox after fix:

Copy link
Owner

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you for doing this!

@theacodes theacodes merged commit af6b00c into theacodes:main Nov 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants