Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup blog #28

Merged
merged 2 commits into from
Apr 19, 2021
Merged

setup blog #28

merged 2 commits into from
Apr 19, 2021

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Apr 13, 2021

Still to do:

  • add page structure for /articles (@MinThaMie do you have design ideas for this?)
  • add page structure for individual articles
  • add model data to both templates so the information will render
  • add links to home page
  • figure out why we have to use ?fastboot=false when developing locally
  • figure out the new deprecation (see comment below)
  • figure out why the build isn't working right now (Error while processing route: articles.article e.getRecord is not a function TypeError: e.getRecord is not a function)

@MelSumner
Copy link
Contributor Author

MelSumner commented Apr 14, 2021

ok this now builds if you append with ?fastboot=false, e.g., http://localhost:4200/articles?fastboot=false
it looks like it's related to this issue - ember-cli/ember-page-title#195 - which was fixed, but somehow that's the same issue we're facing.

But if you go to http://localhost:4200/articles/all.json you'll see the markdown converted to json, so it's otherwise working correctly.

This means that you can:

  • add your author file to the authors folder in this branch
  • add an article as article-name.md in the articles folder

@MelSumner MelSumner changed the title setup blog still need to do models setup blog Apr 14, 2021
@MelSumner MelSumner marked this pull request as ready for review April 14, 2021 02:01
@MelSumner
Copy link
Contributor Author

MelSumner commented Apr 14, 2021

Edit: Resolved.

Also need to look up and see what this issue is about, came with the latest version of Ember:

DEPRECATION: A value was injected implicitly on the '_fastbootInfo' property of an instance of <thezendevapp@service:fastboot::ember161>. Implicit injection is now deprecated, please add an explicit injection for this value. If the injected value is a service, consider using the @service decorator. [deprecation id: implicit-injections] See https://deprecations.emberjs.com/v3.x#toc_implicit-injections for more details.

@MelSumner
Copy link
Contributor Author

Update: It was the pagination feature that was causing the issue. Once I removed that, everything worked fine. Now, there are just a few remaining issues to settle:

  1. The article template can't seem to find the image defined in the article's .md file. I've tried a few formats, thinking maybe I just got it wrong, but it just doesn't seem to want to be there. It does show up in the .json file for the article, so I'll have to go over each file with a fine-tooth comb to see what I am missing. I will also check with @mansona to see if image urls are supported by broccoli-static-site-json or if I have to do something special.
  2. the dateCreated attribute is also not rendering to the page.
  3. I added the links to the homepage but idk about the design of them. @MinThaMie please check the deploy preview & see what you think. I don't know if the colors really work, and the typeface is def not great at that small of a size.

@MelSumner MelSumner linked an issue Apr 18, 2021 that may be closed by this pull request
4 tasks
@MelSumner
Copy link
Contributor Author

MelSumner commented Apr 18, 2021

Ok @MinThaMie it's ready to go.

  • I turned off fingerprinting (I'll turn it back on once I figure out how to define/use them w/front matter- filed an issue requesting clarification)
  • I changed dateCreated to just created so ember-data stopped complaining

updating models

added a serializer to make the magic work

extracted footer to component

fixes models and adds index to articles

adding basic layout to article templates

update styling

Adds blogpost + Anne-Greeth as author

changing targets in config

ran linters and fixed prettier complaints

updating readme

more updates

added missing tag

more updates

adding author model to route

added dynamic page title

article template

extracting primary navbar to component

tweak to navbar

working on some spacing

working on the card element for the article links

more work on article card

trying to fix the error that is causing build failure

tadjusting prember urls

added prember-middleware

removed pagination from in-repo addon config

tweaking primary nav

added links to homepage

few small tweaks

updating styles

updating styles

ember-data forced attribute rename

trying again
@MelSumner
Copy link
Contributor Author

MelSumner commented Apr 19, 2021

Final fixes before merge:

  • changed the image for the first article
  • fixed an issue where the home page was misconfigured on ultra-wide screens
  • added unsplashtext and unsplashurl to article frontmatter and article model so we could attribute images correctly
  • changed the front page nav links a tiny bit (feel free to change these entirely later, if you want to).

@MelSumner MelSumner merged commit 3a3390a into main Apr 19, 2021
@MelSumner MelSumner added this to the add blog milestone Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for blog posts
1 participant