Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #299

Merged
merged 3 commits into from
Jun 4, 2024
Merged

update #299

merged 3 commits into from
Jun 4, 2024

Conversation

tfukaza
Copy link
Owner

@tfukaza tfukaza commented Jun 2, 2024

No description provided.

@tfukaza tfukaza linked an issue Jun 2, 2024 that may be closed by this pull request
@tfukaza tfukaza requested a review from Ryang20718 June 2, 2024 02:40
tfukaza added 2 commits June 1, 2024 20:13
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 44.11%. Comparing base (1fd0a39) to head (2971d88).

Files Patch % Lines
harvest/broker/dummy.py 33.33% 2 Missing ⚠️
harvest/trader/trader.py 33.33% 2 Missing ⚠️
harvest/plugin/_base.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   45.74%   44.11%   -1.64%     
==========================================
  Files          26       26              
  Lines        3834     3833       -1     
==========================================
- Hits         1754     1691      -63     
- Misses       2080     2142      +62     
Flag Coverage Δ
unittests 44.11% <58.33%> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for s in strikes:
for e in expirations:
data.append([symbol, e, t, s])
for typ, strike, expiration in itertools.product(types, strikes, expirations):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

flask-cors == 3.0.10
flask == 3.0.3
rich == 13.7.1
pandas >= 2.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tfukaza tfukaza merged commit 44951fe into main Jun 4, 2024
3 of 4 checks passed
@tfukaza tfukaza deleted the 297-updates branch June 4, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates
2 participants