Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor yf ut #298

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Refactor yf ut #298

merged 2 commits into from
Jun 2, 2024

Conversation

tfukaza
Copy link
Owner

@tfukaza tfukaza commented May 28, 2024

No description provided.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.74%. Comparing base (2f4e20d) to head (878a11a).

Files Patch % Lines
harvest/broker/yahoo.py 84.61% 2 Missing ⚠️
harvest/util/date.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   41.62%   45.74%   +4.12%     
==========================================
  Files          26       26              
  Lines        3825     3834       +9     
==========================================
+ Hits         1592     1754     +162     
+ Misses       2233     2080     -153     
Flag Coverage Δ
unittests 45.74% <87.50%> (+4.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfukaza tfukaza merged commit 1fd0a39 into main Jun 2, 2024
4 checks passed
@tfukaza tfukaza deleted the ut-yf branch June 2, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant