Added Combat ATTACK_DONE_EVENT 0x01A7

[fantoms]

• Added the ATTACK_DONE_EVENT: // 0x01A7
  This message returns an integer and I set the label to NumberOfAttacks, as described in skunkworks: http://skunkworks.sourceforge.net/protocol/Protocol.php?stylesheet=Classic.css&frame=frameMsg&type=F7B0&case=0x01A7

[tfarley]

Have you found any of these packets in pcaps? I'm not too sure this is actually the number of attacks. The only way it's used in the client code is that it will abort auto-attacking if it's non-zero. It's also called "etype" as a local var, which matches up with some other event handlers that have parameters also called "etype". Those handlers branch on etype's various values to do different things.

I'm thinking that this is actually something more like "event type" where a value of 1 means to stop auto-attacking and any other value doesn't do anything.

[fantoms]

Yes, I have seen most of these packet's show up as mostly 0, but every once and awhile there is a positive integer present. The values I have witnessed as a uint: 0, 2, 39, 55, 56, 57, 59 - so I am not confident that this message is truely, the number of attacks.

[tfarley]

Interesting. Could you please add a TODO comment to investigate this one a little more, to determine (or verify) what the field might be? Just since it's not easy to confirm what it actually is via the client, and skunkworks has been known to be a bit off or outdated for some packets. Looks good otherwise.

[fantoms]

Sorry for the confusion, accidentally deleted this branch and restored in my github.

[fantoms]

Here are the results from doing a quick count of the values that come back from ATTACK_DONE, utilizing 2,376 PCAP files:

value : occurrences total

0 : 255,702
2 : 2,140
14 : 3
29 : 550
31 : 1
35 : 115
54 : 6,698
55 : 4,717
56 : 2,427
57 : 5,795
58 : 50
60 : 1
61 : 203
75 : 47
1016 : 42
1067 : 24
1073 : 7