wasi: add more test cases to poll_oneoff, cleanup impl #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evacchi
force-pushed
the
poll-misc-fixes
branch
from
9dc3fba
to
4e2f0b3
Compare
evacchi
commented
Aug 4, 2023
| @@ -192,7 +199,6 @@ func Test_pollOneoff_Stdin(t *testing.T) { | |||
| mem: concat( | |||
| clockNsSub(20*1000*1000), | |||
| fdReadSub, | |||
| singleton('?'), | |||
There was a problem hiding this comment.
these really aren't necessary as mem is pre-touched with '?' anyway.
evacchi
commented
Aug 4, 2023
| @@ -90,6 +90,16 @@ func syscallConnControl(conn syscall.Conn, fn func(fd uintptr) (int, sys.Errno)) | |||
| return | |||
| } | |||
|
|
|||
| func _pollSock(conn syscall.Conn, flag sys.Pflag, timeoutMillis int32) (bool, sys.Errno) { | |||
There was a problem hiding this comment.
this utility may be also useful if we expose File.Poll() in sockets too
Signed-off-by: Edoardo Vacchi <[email protected]>
evacchi
force-pushed
the
poll-misc-fixes
branch
from
4e2f0b3
to
e17b921
Compare
codefromthecrypt
approved these changes
Aug 5, 2023
jerbob92
pushed a commit
to jerbob92/wazero
that referenced
this pull request
Aug 9, 2023
) Signed-off-by: Edoardo Vacchi <[email protected]> Signed-off-by: Jeroen Bobbeldijk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #1606. Cleanup for some logic in
poll_oneoffand add more test cases+fix nonblocking flags in sockets.