Remove unnecessary else

terremoth · Feb 22, 2024 · 8f9a2e2 · 8f9a2e2
1 parent c07be1f
commit 8f9a2e2
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/BoxDesigner/Rectangle.php b/src/BoxDesigner/Rectangle.php
@@ -6,7 +6,7 @@
 
 class Rectangle
 {
-    protected string $content = ' ';
+    protected string $content = '';
 
     /**
      * @throws SideLessThanOneException
@@ -64,22 +64,24 @@ public function draw(LineAsciiCharsInterface|null $lineDrawerProvider = null): s
         $columns = $this->columns + $sumTheBorders;
 
         $contentCharPosition = 0;
+        $this->content = str_replace("\r", '', $this->content);
         $contentLength = strlen($this->content);
 
         for ($row = 0; $row < $this->rows; $row++) {
             for ($column = 0; $column < $columns; $column++) {
                 if ($column == 0 || $column == ($columns - 1)) {
                     $rectangleBox .= $lineDrawerProvider->verticalLine();
-                } else {
-                    $add = ' ';
+                    continue;
+                }
 
-                    if ($this->content != ' ' && $contentCharPosition < $contentLength) {
-                        $add = $this->content[$contentCharPosition];
-                        $contentCharPosition++;
-                    }
+                $add = ' ';
 
-                    $rectangleBox .= $add;
+                if ($this->content != '' && $contentCharPosition < $contentLength) {
+                    $add = $this->content[$contentCharPosition];
+                    $contentCharPosition++;
                 }
+
+                $rectangleBox .= $add;
             }
 
             $rectangleBox .= PHP_EOL;