Bump @carbon/react from 1.65.0 to 1.68.0 #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a number of fixes for the ComboBox component, including properly clearing state when the user clicks the 'clear' button, so our workaround for this is no longer required. It also includes a number of a11y improvements for various components. However, it also introduces a breaking change for the ComboBox related to use of the `selectedItem` prop. Previously this did not behave consistently as a fully controlled component, however with this update it now does, resulting in a number of our existing workarounds for the old behaviour becoming problematic. This will likely require significant refactoring of some of the code, specifically around the `NamespacesDropdown` and the `ALL_NAMESPACES` item, as these appear to cause the Carbon component to lock up / go into a loop. This manifested as OOM issues with unit tests in CI, as well as failure of the E2E in CI. Running locally produced intermittent errors, including hanging tests for `HeaderBarContent` and `CreateTaskRun`, both of which exercise the `NamespacesDropdown`. Temporarily switch use of `selectedItem` to `initialSelectedItem` to maintain the existing behaviour so we can benefit from the other fixes included in this update.
tekton-robot
added
kind/misc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaces #3662
This includes a number of fixes for the ComboBox component, including properly clearing state when the user clicks the 'clear' button, so our workaround for this is no longer required.
It also includes a number of a11y improvements for various components.
However, it also introduces a breaking change for the ComboBox related to use of the
selectedItemprop. Previously this did not behave consistently as a fully controlled component, however with this update it now does, resulting in a number of our existing workarounds for the old behaviour becoming problematic. This will likely require significant refactoring of some of the code, specifically around theNamespacesDropdownand theALL_NAMESPACESitem, as these appear to cause the Carbon component to lock up / go into a loop. This manifested as OOM issues with unit tests in CI, as well as failure of the E2E in CI. Running locally produced intermittent errors, including hanging tests forHeaderBarContentandCreateTaskRun, both of which exercise theNamespacesDropdown.Temporarily switch use of
selectedItemtoinitialSelectedItemto maintain the existing behaviour so we can benefit from the other fixes included in this update./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes