Bugfix/object removal performance #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::vector::remove is slow in large arrays, simply swapping with the last item and resizing is faster.
Previously, it was done using nested loops over HdBlackbird's instances and coreBlackbird's object array. Now it's two sequential loops. Especially in the case of millions of instances, this makes exiting a render much faster.
skwerner
requested review from
bareya,
boberfly,
dedoardo,
sergeneren and
Vochsel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance improvement that brings scenes that were previously unusuably slow to reasonable performance. In cases of hundreds of thousands of instances, exiting hdBlackbird would previously take 30min or longer, now it's down to about one minute.
This is not intended as a replacement for #161 but rather a quick fix until that one is ready.