feat(taiko-client): propose blocks with revert protection #18590
Conversation
| @@ -190,7 +190,7 @@ func (b *BlobTransactionBuilder) BuildOntake( | |||
| } | |||
| txListArray := make([][]byte, len(encodedParamsArray)) | |||
| if b.proverSetAddress != rpc.ZeroAddress { | |||
| data, err = encoding.ProverSetABI.Pack("proposeBlocksV2", encodedParamsArray, txListArray) | |||
| data, err = encoding.ProverSetABI.Pack("proposeBlocksV2Conditionally", encodedParamsArray, txListArray) | |||
There was a problem hiding this comment.
Shall we make this feature as a new flag?
There was a problem hiding this comment.
I think this is feature is benefit for all users. Without this feature, user would propose empty blocks and verify blocks with much gas and get no reward. If all users apply this feature, it will cost little gas and revert tx even thought without the support of revert protection from endpoint.
There was a problem hiding this comment.
Emm but then it will be a force upgrade of proverSet for all community proposers when we release a new version of client? I think if we still keep proposeBlocksV2 in proverSet, we should still support that path in client?
There was a problem hiding this comment.
OK, will change it as an optional flag.
No description provided.