feat(taiko-client): p2p network for soft block sharing #18528
Conversation
| @@ -90,13 +108,19 @@ func (d *Driver) InitFromConfig(ctx context.Context, cfg *Config) (err error) { | |||
|
|
|||
| d.l1HeadSub = d.state.SubL1HeadsFeed(d.l1HeadCh) | |||
|
|
|||
| d.p2pnetwork, err = p2p.NewNetwork(d.ctx, d.Config.P2PNetworkBootstrapNodeURL, d.Config.P2PNetworkPort) | |||
There was a problem hiding this comment.
Maybe we need another flag to open or close p2pnetwork.
|
If some peers offlined how can we know or do we need to manage it? |
| }) | ||
| } | ||
|
|
||
| func (n *Network) Close() error { |
There was a problem hiding this comment.
Call this function in driver.Close().
| } | ||
|
|
||
| func JoinTopic[T any](_ context.Context, n *Network, topicName string, topicHandler topicHandlerFunc[T]) error { | ||
| topic, err := n.ps.Join(topicName) |
There was a problem hiding this comment.
Repeated calls will report error
| @@ -185,6 +131,16 @@ func (s *SoftBlockAPIServer) BuildSoftBlock(c echo.Context) error { | |||
| } | |||
| } | |||
|
|
|||
| // publish to network | |||
| if err := p2p.Publish[softblocks.TransactionBatch]( | |||
There was a problem hiding this comment.
Check s.p2pNetwork != nil at first.
|
When starting a boot node peer, it is recommended to support a private key for a fixed Peer ID. |
the actual p2p will be in a sidecar not directly in client most likely, this is just a basic POC. |
Ok, from a proof-of-concept perspective, it's enough. |
No description provided.