darp7: Hack-fix power-on issue #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any side effect to this (like having to hold down the power button noticeably longer), or is this a fix we'd be able to ship? |
|
On AC it should not be noticeable, since the delay will happen when AC power is connected, not when the power button is pressed. On battery it may be noticeable, since pressing the power button is what turns the EC on in the first place. It will increase the time needed to hold the button from ~100 ms to ~300 ms. |
The power button should be disabled when a machine is unplugged with the lid closed. On darp7, `LID_SW#` can take >200ms at init to reflect the correct state of the lid, so it would regularly fail the check. It was common for the board to still power on. Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
force-pushed
the
darp7-delay
branch
from
36baf71 to
d9131a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The power button should be disabled when a machine is unplugged with the lid closed. On darp7,
LID_SW#can take >200ms at init to reflect the correct state of the lid, so it would regularly fail the check. It was common for the board to still power on.Ref: #233